feat(Tag): Implement tag color #1727
Conversation
There was a problem hiding this comment.
Works as described. I have some comments.
What's the purpose for having the endpoints return ProjectAndTagsResponse? It doesn't look like this response is used in any of the components that call the endpoints. Should the endpoints return void instead?
CreateTagDialogComponent and EditTagDialogComponent are very similar. Should we extract common code to an abstract class?
Manage Tags UI/UX has veered a bit from our designs (https://balsamiq.cloud/s8brvqj/p9j1not/rEB79 and https://balsamiq.cloud/s8brvqj/p9j1not/r24F3). Should we allow editing (tag name, tag color) directly in the Manage Tags dialog?
Also, I don't think we should have the author type in a color because we don't want users typing in dark colors like "black" and "blue", which would make the tag text difficult to read. How difficult is it to add a color chooser, like a grid of pre-selected soft colors?
Changes
Test